Merge lp://staging/~vanvugt/mir/fix-1686620 into lp://staging/mir
Status: | Merged |
---|---|
Approved by: | Alberto Aguirre |
Approved revision: | no longer in the source branch. |
Merged at revision: | 4158 |
Proposed branch: | lp://staging/~vanvugt/mir/fix-1686620 |
Merge into: | lp://staging/mir |
Diff against target: |
29 lines (+19/-0) 1 file modified
examples/eglapp.c (+19/-0) |
To merge this branch: | bzr merge lp://staging/~vanvugt/mir/fix-1686620 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alberto Aguirre (community) | Approve | ||
Mir CI Bot | continuous-integration | Approve | |
Review via email: mp+323378@code.staging.launchpad.net |
Commit message
Ensure fullscreen eglapps that request initial state 'fullscreen'
know their actual buffer dimensions in time to set up glViewport
and render their first frame (LP: #1686620)
Since r4134 they were getting 0x0 from mir_eglapp_init and using
that to set a 0x0 viewport. So the window would remain black until
resized.
Description of the change
Providing resize events asynchronously is fine, but apps also need to know a sane size before that first resize callback, when they're already rendering their first frame.
Sadly that first resize callback is not guaranteed to occur before mir_create_
PASSED: Continuous integration, rev:4162 /mir-jenkins. ubuntu. com/job/ mir-ci/ 3382/ /mir-jenkins. ubuntu. com/job/ build-mir/ 4577 /mir-jenkins. ubuntu. com/job/ build-0- fetch/4704 /mir-jenkins. ubuntu. com/job/ build-1- sourcepkg/ release= xenial+ overlay/ 4693 /mir-jenkins. ubuntu. com/job/ build-1- sourcepkg/ release= zesty/4693 /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= amd64,compiler= clang,platform= mesa,release= zesty/4609 /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= amd64,compiler= clang,platform= mesa,release= zesty/4609/ artifact/ output/ *zip*/output. zip /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= amd64,compiler= gcc,platform= mesa,release= xenial+ overlay/ 4609 /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= amd64,compiler= gcc,platform= mesa,release= xenial+ overlay/ 4609/artifact/ output/ *zip*/output. zip /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= amd64,compiler= gcc,platform= mesa,release= zesty/4609 /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= amd64,compiler= gcc,platform= mesa,release= zesty/4609/ artifact/ output/ *zip*/output. zip /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= cross-armhf, compiler= gcc,platform= mesa,release= zesty/4609 /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= cross-armhf, compiler= gcc,platform= mesa,release= zesty/4609/ artifact/ output/ *zip*/output. zip /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= i386,compiler= gcc,platform= mesa,release= xenial+ overlay/ 4609 /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= i386,compiler= gcc,platform= mesa,release= xenial+ overlay/ 4609/artifact/ output/ *zip*/output. zip
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild: /mir-jenkins. ubuntu. com/job/ mir-ci/ 3382/rebuild
https:/