Merge lp://staging/~vanvugt/mir/fix-1671033 into lp://staging/mir
Proposed by
Daniel van Vugt
| Status: | Merged |
|---|---|
| Approved by: | Daniel van Vugt |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 4086 |
| Proposed branch: | lp://staging/~vanvugt/mir/fix-1671033 |
| Merge into: | lp://staging/mir |
| Diff against target: |
33 lines (+7/-5) 2 files modified
tests/mir_test_doubles/fake_alarm_factory.cpp (+6/-4) tests/unit-tests/scene/test_mediating_display_changer.cpp (+1/-1) |
| To merge this branch: | bzr merge lp://staging/~vanvugt/mir/fix-1671033 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Alan Griffiths | Approve | ||
| Mir CI Bot | continuous-integration | Approve | |
|
Review via email:
|
|||
Commit message
Optimize a crazily inefficient test case (LP: #1671033)
Not a threading problem this time, but a general algorithmic complexity
problem. The test itself was running 50x longer than it needs to, and
the FakeAlarmFactory class it uses was copying a vector 3 million times during the one test case (now zero times).
Execution times under valgrind:
Before: 30 seconds; After: 0.7 seconds
Execution times natively:
Before: 0.8 seconds; After: 0.01 seconds
Description of the change
Note the above times are from a fast Xeon. CI logs show the test was taking minutes in CI.
To post a comment you must log in.
Revision history for this message
| Mir CI Bot (mir-ci-bot) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
PASSED: Continuous integration, rev:4087
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/