Merge lp://staging/~vanvugt/gtk/fix-1698270 into lp://staging/~ubuntu-desktop/gtk/ubuntugtk3

Proposed by Daniel van Vugt
Status: Rejected
Rejected by: Jeremy Bícha
Proposed branch: lp://staging/~vanvugt/gtk/fix-1698270
Merge into: lp://staging/~ubuntu-desktop/gtk/ubuntugtk3
Diff against target: 112 lines (+92/-0)
3 files modified
debian/changelog (+8/-0)
debian/patches/Fix-irregular-gdk_frame_clock_get_frame_time-v3-ubuntu.patch (+83/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp://staging/~vanvugt/gtk/fix-1698270
Reviewer Review Type Date Requested Status
Jeremy Bícha Disapprove
Ubuntu Sponsors Pending
Review via email: mp+331846@code.staging.launchpad.net

Commit message

Fix irregular gdk_frame_clock_get_frame_time

This fixes stuttering in animations that rely on the regularity of
gdk_frame_clock_get_frame_time. (LP: #1698270)

BEFORE

gdkgears: 58 FPS and visibly stuttering

gnome-maps on a 59.95Hz monitor:
"paint" gdk_frame_clock_get_frame_time +17278μs
"paint" gdk_frame_clock_get_frame_time +17426μs
"paint" gdk_frame_clock_get_frame_time +17600μs
^^^ misses about 5% of frames, or stutters 3 times per sec ^^^

AFTER

gdkgears: 60 FPS and smoother

gnome-maps on a 59.95Hz monitor:
"paint" gdk_frame_clock_get_frame_time +16680μs
"paint" gdk_frame_clock_get_frame_time +16680μs
"paint" gdk_frame_clock_get_frame_time +16680μs
^^^ misses no frames ^^^

To post a comment you must log in.
579. By Daniel van Vugt

Merge latest 'ubuntugtk3' and fix changelog conflict.

580. By Daniel van Vugt

Merge latest 'ubuntugtk3' and fix changelog conflict.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

This patch has now landed upstream (on master GTK+4.0 only I think)
https://git.gnome.org/browse/gtk+/commit/?id=3b2f9395905ec2d9696bcf51497781236c95ec63

Revision history for this message
Jeremy Bícha (jbicha) wrote :

I'm rejecting this merge proposal because we got the fix upstream in 3.22.28 which has now landed in bionic:
https://launchpad.net/ubuntu/+source/gtk+3.0/3.22.28-1ubuntu1

Thanks!

review: Disapprove

Unmerged revisions

580. By Daniel van Vugt

Merge latest 'ubuntugtk3' and fix changelog conflict.

579. By Daniel van Vugt

Merge latest 'ubuntugtk3' and fix changelog conflict.

578. By Daniel van Vugt

First import

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches