Compiz

Merge lp://staging/~vanvugt/compiz/fix-1005569.1 into lp://staging/compiz/0.9.8

  1. fix-1005569.1
  2. Merge into 0.9.8
Proposed by Daniel van Vugt
Status: Merged
Merged at revision: 3236
Proposed branch: lp://staging/~vanvugt/compiz/fix-1005569.1
Merge into: lp://staging/compiz/0.9.8
Diff against target: 74 lines (+20/-15)
1 file modified
src/event.cpp (+20/-15)
To merge this branch: bzr merge lp://staging/~vanvugt/compiz/fix-1005569.1
Reviewer Review Type Date Requested Status
Sam Spilsbury Approve
Review via email: mp+107942@code.staging.launchpad.net

Description of the change

Avoid constructing and destructing lots of strings on every single event,
which was wasting lots of CPU (LP: #1005569)

To post a comment you must log in.
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

I'm fine with this going in as is, but the code needs to be redesigned tbh, the abstraction is terrible.

review: Approve
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I did recommend:
https://code.launchpad.net/~vanvugt/compiz/fix-1005569.2/+merge/107941
over this proposal.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches