Compiz Core

Merge lp://staging/~vanvugt/compiz-core/fix-988684 into lp://staging/compiz-core/0.9.8

fix-988684
Merge into 0.9.8

Proposed by Daniel van Vugt on 2012-04-27

Status:	Merged
Merged at revision:	3115
Proposed branch:	lp://staging/~vanvugt/compiz-core/fix-988684
Merge into:	lp://staging/compiz-core/0.9.8
Diff against target:	12 lines (+0/-3) 1 file modified src/screen.cpp (+0/-3)
To merge this branch:	bzr merge lp://staging/~vanvugt/compiz-core/fix-988684
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Sam Spilsbury		2012-04-27	Approve on 2012-04-27
Review via email: mp+103842@code.staging.launchpad.net

This proposal supersedes a proposal from 2012-04-27.

Description of the change

Don't clear selections in ~PrivateScreen because it causes a race between
the existing and the new compiz instances, breaking --replace and non-replace
behaviour. (LP: #988684) (LP: #989545)

This simply deletes two lines of code I introduced in my cleanup r3108.

Revision history for this message

Sam Spilsbury (smspillaz) wrote on 2012-04-27:

Hmm, it should be possible to clear the selection after destroying the selection window. The new selection owner is waiting for the window to be destroyed after requesting to take the selection.

In any case, the selection owner is implicitly cleared when the connection is closed anyways (or at least ... it should be)

review: Approve