usn.ubuntu.com

Merge usn.ubuntu.com:database-files into usn.ubuntu.com:master

Git
lp:usn.ubuntu.com
database-files
Merge into master

Proposed by Will Moggridge on 2018-02-14

Status:	Merged
Approved by:	Robin Winslow on 2018-02-15
Approved revision:	844821d53023ceba2c6a51794f36d69925fdcc62
Merged at revision:	844821d53023ceba2c6a51794f36d69925fdcc62
Proposed branch:	usn.ubuntu.com:database-files
Merge into:	usn.ubuntu.com:master
Diff against target:	65 lines (+25/-3) 3 files modified .gitignore (+0/-1) Dockerfile (+20/-2) nginx.conf (+5/-0)
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Robin Winslow (community)		2018-02-14	Approve on 2018-02-15
Review via email: mp+337727@code.staging.launchpad.net

Description of the change

Add database files to the deployed site.

## QA

Build and run docker image:

- `./run build`
- `docker build --tag usn --build-arg COMMIT_ID="$(git rev-parse HEAD)" .`
- `docker run --rm -p 80:80 -it usn`

Visit http://localhost/usn/usn-db/database-all.pickle.bz2

It should redirect you to http://localhost/database/database-all.pickle.bz2 and download

Revision history for this message

Robin Winslow (nottrobin) wrote on 2018-02-14:

Some comments inline.

review: Needs Fixing

Revision history for this message

Will Moggridge (willmoggridge) wrote on 2018-02-15:

I have updated following those comments.

I added a commit to remove the unneeded public gitignore, doesn't hurt. This MP didn't do anything with those lines though, it just had no newline at the end of the file.

Revision history for this message

Robin Winslow (nottrobin) wrote on 2018-02-15:

Perfect, LGTM +1

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.