Merge lp://staging/~ursinha/ubuntu-ci-services-itself/private-only-is-env-variable into lp://staging/ubuntu-ci-services-itself
Proposed by
Ursula Junque
| Status: | Merged |
|---|---|
| Approved by: | Andy Doan |
| Approved revision: | 391 |
| Merged at revision: | 396 |
| Proposed branch: | lp://staging/~ursinha/ubuntu-ci-services-itself/private-only-is-env-variable |
| Merge into: | lp://staging/ubuntu-ci-services-itself |
| Diff against target: |
197 lines (+46/-9) 7 files modified
juju-deployer/configs/unit_config.yaml.tmpl (+1/-1) juju-deployer/deploy.py (+33/-0) juju-deployer/test_deploy.py (+1/-0) ppa-assigner/ppa_assigner/api.py (+1/-1) ppa-assigner/ppa_assigner/models.py (+1/-1) ppa-assigner/ppa_assigner/settings.py (+1/-1) ppa-assigner/ppa_assigner/tests.py (+8/-5) |
| To merge this branch: | bzr merge lp://staging/~ursinha/ubuntu-ci-services-itself/private-only-is-env-variable |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Evan (community) | Approve | ||
| Andy Doan (community) | Approve | ||
| PS Jenkins bot (community) | continuous-integration | Approve | |
|
Review via email:
|
|||
Commit message
Trying to clarify the use of private ppas, adding an option to set that during deployment time
Description of the change
* PRIVATE_PPA renamed to PRIVATE_PPAS_ONLY
* It's no longer hardcoded on unit_config.
* CI_PRIVATE_
* You can set the environment variable with 0 (disabled) or 1 (enabled).
* If you provide --private-ppas-only to deploy.py, it will ignore the env. variable and enable private PPAs.
* If nothing is provided to deploy.py, it assumes CI_PRIVATE_
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
PASSED: Continuous integration, rev:391
http://
Executed test runs:
Click here to trigger a rebuild:
http://