Merge lp://staging/~ursinha/ubuntu-ci-services-itself/cli-check-changes-file into lp://staging/ubuntu-ci-services-itself
Proposed by
Ursula Junque
Status: | Merged |
---|---|
Approved by: | Chris Johnston |
Approved revision: | 253 |
Merged at revision: | 250 |
Proposed branch: | lp://staging/~ursinha/ubuntu-ci-services-itself/cli-check-changes-file |
Merge into: | lp://staging/ubuntu-ci-services-itself |
Diff against target: |
244 lines (+138/-6) 6 files modified
cli/ci_libs/file_handler.py (+13/-2) cli/tests/data/foobar_0.1-1_dsc.changes (+19/-0) cli/tests/data/foobar_0.1-1_random.changes (+8/-0) cli/tests/test_cli.py (+69/-2) cli/tests/test_file_handler.py (+14/-1) cli/ubuntu-ci (+15/-1) |
To merge this branch: | bzr merge lp://staging/~ursinha/ubuntu-ci-services-itself/cli-check-changes-file |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Chris Johnston (community) | Approve | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Review via email:
|
Commit message
Adds validation to the cli's source package files extension (.changes), also adds better error handling in case the file is named .changes but it's not valid
Description of the change
As pointed by ev this morning, it's possible to provide any kind of source package upload files to the cli, not only .changes, and this makes the cli break horribly.
This branch adds a check if the provided file has the extension .changes, and if not, aborts. Also it adds better exception handling in case the file has a .changes extension but it's not a valid file.
To post a comment you must log in.
FAILED: Continuous integration, rev:251 s-jenkins. ubuntu- ci:8080/ job/uci- engine- ci/172/
http://
Executed test runs:
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/uci- engine- ci/172/ rebuild
http://