Merge lp://staging/~ursinha/ubuntu-ci-services-itself/bug-1283090 into lp://staging/ubuntu-ci-services-itself
Proposed by
Ursula Junque
| Status: | Merged |
|---|---|
| Approved by: | Chris Johnston |
| Approved revision: | 260 |
| Merged at revision: | 263 |
| Proposed branch: | lp://staging/~ursinha/ubuntu-ci-services-itself/bug-1283090 |
| Merge into: | lp://staging/ubuntu-ci-services-itself |
| Diff against target: |
133 lines (+64/-3) 5 files modified
cli/ci_libs/file_handler.py (+7/-0) cli/tests/data/foobar_0.1-1_unreleased.changes (+28/-0) cli/tests/test_cli.py (+18/-0) cli/tests/test_file_handler.py (+8/-2) cli/ubuntu-ci (+3/-1) |
| To merge this branch: | bzr merge lp://staging/~ursinha/ubuntu-ci-services-itself/bug-1283090 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
| Evan (community) | Approve | ||
|
Review via email:
|
|||
Commit message
In the CLI, ensure the source package is targeted to a release, not marked as UNRELEASED.
Description of the change
This branch adds .changes validation to the cli, checking if the source is marked UNRELEASED and rejecting it if so, as this will cause Launchpad to reject the upload down the line.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
FAILED: Continuous integration, rev:260
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https:/
http://
Executed test runs:
Click here to trigger a rebuild:
http://