Merge lp://staging/~uriboni/camera-app/use-camera-orientation into lp://staging/camera-app/staging

Proposed by Ugo Riboni
Status: Needs review
Proposed branch: lp://staging/~uriboni/camera-app/use-camera-orientation
Merge into: lp://staging/camera-app/staging
Prerequisite: lp://staging/~uriboni/camera-app/switch-via-camera-position-api
Diff against target: 83 lines (+6/-24)
3 files modified
ViewFinderOverlay.qml (+2/-3)
ViewFinderOverlayLoader.qml (+0/-2)
ViewFinderView.qml (+4/-19)
To merge this branch: bzr merge lp://staging/~uriboni/camera-app/use-camera-orientation
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+286499@code.staging.launchpad.net

Commit message

Use Camera.orientation to compensate for the physical angle the sensor is mounted at within the device

Description of the change

Use Camera.orientation to compensate for the physical angle the sensor is mounted at within the device

Note that https://code.launchpad.net/~uriboni/qtubuntu-camera/cameras-info is needed for this to work, and the prerequisite camera-app branch is also needed for the orientation to be correctly picked up when switching cameras (since the method we used previously to switch cameras did not cause
the QML Camera to update properties such as the orientation)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Florian Boucault (fboucault) wrote :

feafea

Unmerged revisions

652. By Ugo Riboni

Use Camera.orientation to compensate for sensor physical orientation instead of hardcoding it

651. By Ugo Riboni

Merge from prerequisite branch

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches