Merge lp://staging/~uriboni/camera-app/share-multiple-items into lp://staging/camera-app/staging
Proposed by
Ugo Riboni
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Florian Boucault | ||||
Approved revision: | 670 | ||||
Merged at revision: | 665 | ||||
Proposed branch: | lp://staging/~uriboni/camera-app/share-multiple-items | ||||
Merge into: | lp://staging/camera-app/staging | ||||
Diff against target: |
396 lines (+243/-20) 8 files modified
GalleryView.qml (+1/-3) PhotogridView.qml (+30/-4) UnableShareDialog.qml (+34/-0) camera-app.qml (+1/-1) debian/control (+3/-0) tests/autopilot/camera_app/tests/test_gallery_view.py (+85/-11) tests/unittests/CMakeLists.txt (+1/-1) tests/unittests/tst_PhotogridView.qml (+88/-0) |
||||
To merge this branch: | bzr merge lp://staging/~uriboni/camera-app/share-multiple-items | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot | continuous-integration | Needs Fixing | |
Florian Boucault (community) | Needs Fixing | ||
Review via email:
|
Commit message
Allow sharing multiple files, except if they are mixed content
Description of the change
Allow sharing multiple files, except if they are mixed content
To post a comment you must log in.
code in PhotogridView. qml/onTriggered could be written in a clearer way, for example:
onTriggered: { ixedTypes( )) { open(unableShar eDialogComponen t).parent = photogridView; open(sharePopov erComponent) .parent = photogridView;
if (selectedFilesM
PopupUtils.
} else {
PopupUtils.
}
}