camera-app

Merge lp://staging/~uriboni/camera-app/reset-zoom-ui into lp://staging/camera-app/staging

  1. reset-zoom-ui
  2. Merge into staging
Proposed by Florian Boucault
Status: Merged
Approved by: Florian Boucault
Approved revision: 603
Merged at revision: 609
Proposed branch: lp://staging/~uriboni/camera-app/reset-zoom-ui
Merge into: lp://staging/camera-app/staging
Diff against target: 204 lines (+80/-28)
4 files modified
ViewFinderOverlay.qml (+7/-0)
tests/autopilot/camera_app/emulators/main_window.py (+20/-1)
tests/autopilot/camera_app/tests/test_capture.py (+6/-27)
tests/autopilot/camera_app/tests/test_zoom.py (+47/-0)
To merge this branch: bzr merge lp://staging/~uriboni/camera-app/reset-zoom-ui
Reviewer Review Type Date Requested Status
Florian Boucault Pending
PS Jenkins bot continuous-integration Pending
Review via email: mp+278612@code.staging.launchpad.net

This proposal supersedes a proposal from 2015-11-18.

Commit message

Correctly reset the zoom UI when the actual zoom level of the camera resets due to switching cameras or recording modes

Description of the change

Correctly reset the zoom UI when the actual zoom level of the camera resets due to switching cameras or recording modes

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:600
http://jenkins.qa.ubuntu.com/job/camera-app-ci/455/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-amd64-ci/151
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-armhf-ci/151
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-armhf-ci/151/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-i386-ci/151
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/309/console
    ABORTED: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-touch/968/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/809
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25237

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/455/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Florian Boucault (fboucault) wrote : Posted in a previous version of this proposal

We have a binding one way.

         Binding { target: camera; property: "currentZoom"; value: zoomControl.value }

We ideally would want one the other way no? This could probably be achieved without binding loop issues with something like:

Connections {
   target: camera
   onCurrentZoomChanged: zoomControl.value = camera.currentZoom
}

review: Needs Information
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:600
http://jenkins.qa.ubuntu.com/job/camera-app-ci/458/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-amd64-ci/154
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-armhf-ci/154
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-armhf-ci/154/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-i386-ci/154
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/312
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-touch/973
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/814
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25260

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/458/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:600
http://jenkins.qa.ubuntu.com/job/camera-app-ci/461/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-amd64-ci/157
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-armhf-ci/157
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-armhf-ci/157/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-i386-ci/157
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/315
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-touch/976
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/817
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25277

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/461/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:601
http://jenkins.qa.ubuntu.com/job/camera-app-ci/464/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-amd64-ci/160
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-armhf-ci/160
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-armhf-ci/160/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-i386-ci/160
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/318
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-touch/979
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/820
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25299

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/464/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:601
http://jenkins.qa.ubuntu.com/job/camera-app-ci/469/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-amd64-ci/165
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-armhf-ci/165
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-armhf-ci/165/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-i386-ci/165
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/324
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-touch/985
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/828
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25394

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/469/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ugo Riboni (uriboni) wrote : Posted in a previous version of this proposal

> We have a binding one way.
>
> Binding { target: camera; property: "currentZoom"; value:
> zoomControl.value }
>
> We ideally would want one the other way no? This could probably be achieved
> without binding loop issues with something like:
>
> Connections {
> target: camera
> onCurrentZoomChanged: zoomControl.value = camera.currentZoom
> }

This actually causes lots of binding loop warnings when zooming, as the value changes:

ViewFinderOverlay.qml:743:13: QML Binding: Binding loop detected for property "value"

I don't think they are a problem, but it still not nice to have them. Should I revert to my previous implementation ?

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:603
http://jenkins.qa.ubuntu.com/job/camera-app-ci/474/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-amd64-ci/170
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-armhf-ci/170
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-armhf-ci/170/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-i386-ci/170
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/332
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-touch/993
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/837
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25477

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/474/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches