U1DB Qt/ QML

Merge lp://staging/~uonedb-qt/u1db-qt/dateStrings into lp://staging/u1db-qt

  1. dateStrings
  2. Merge into trunk
Proposed by Cris Dywan
Status: Needs review
Proposed branch: lp://staging/~uonedb-qt/u1db-qt/dateStrings
Merge into: lp://staging/u1db-qt
Diff against target: 26 lines (+16/-0)
1 file modified
tests/tst_database.qml (+16/-0)
To merge this branch: bzr merge lp://staging/~uonedb-qt/u1db-qt/dateStrings
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
U1DB Qt developers Pending
Review via email: mp+267371@code.staging.launchpad.net

Commit message

Test storing and retrieving of date strings

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:126
http://jenkins.qa.ubuntu.com/job/u1db-qt-ci/68/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/u1db-qt-vivid-amd64-ci/15/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/u1db-qt-vivid-armhf-ci/15/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/u1db-qt-ci/68/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

This test pass, but I wonder if it's not because the timezone is in UTC, I guess you should explicitely change the timzeone in the test (or add another test which changes the timezone before putting it in the database)

Reply
lp://staging/~uonedb-qt/u1db-qt/dateStrings updated
127. By Cris Dywan

No need to hard-code a date for testing

Revision history for this message
Cris Dywan (kalikiana) wrote :

> This test pass, but I wonder if it's not because the timezone is in UTC, I
> guess you should explicitely change the timzeone in the test (or add another
> test which changes the timezone before putting it in the database)

I used the exact string you gave me as an example. It would help if you could tell me how you get the date string to begin with - Date.toISOString() always uses UTC and there's no standard Javascript method to get an ISO string with a timezone.

Reply
Revision history for this message
Cris Dywan (kalikiana) wrote :

> This test pass, but I wonder if it's not because the timezone is in UTC, I
> guess you should explicitely change the timzeone in the test (or add another
> test which changes the timezone before putting it in the database)

I used the exact string you gave me as an example. It would help if you could tell me how you get the date string to begin with - Date.toISOString() always uses UTC and there's no standard Javascript method to get an ISO string with a timezone.

Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:127
http://jenkins.qa.ubuntu.com/job/u1db-qt-ci/69/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/u1db-qt-vivid-amd64-ci/16/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/u1db-qt-vivid-armhf-ci/16/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/u1db-qt-ci/69/rebuild

review: Needs Fixing (continuous-integration)
Reply

Unmerged revisions

127. By Cris Dywan

No need to hard-code a date for testing

126. By Cris Dywan

Test storing and retrieving of date strings

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: