Unity 8

Merge lp://staging/~unity-team/unity8/oobe-set-osk into lp://staging/unity8

  1. oobe-set-osk
  2. Merge into trunk
Proposed by Michael Terry
Status: Merged
Approved by: Lukáš Tinkl
Approved revision: 2156
Merged at revision: 2293
Proposed branch: lp://staging/~unity-team/unity8/oobe-set-osk
Merge into: lp://staging/unity8
Prerequisite: lp://staging/~unity-team/unity8/oobe
Diff against target: 61 lines (+30/-1)
3 files modified
qml/Wizard/Pages/10-welcome.qml (+8/-1)
tests/mocks/Ubuntu/SystemSettings/LanguagePlugin/MockKeyboardPlugin.qml (+21/-0)
tests/mocks/Ubuntu/SystemSettings/LanguagePlugin/qmldir (+1/-0)
To merge this branch: bzr merge lp://staging/~unity-team/unity8/oobe-set-osk
Reviewer Review Type Date Requested Status
Lukáš Tinkl (community) Approve
Unity8 CI Bot continuous-integration Needs Fixing
Review via email: mp+289436@code.staging.launchpad.net

Commit message

Fix setting OSK layout in OOBE wizard

Description of the change

Set OSK layout when changing language. The language plugin used to do this, but with another branch [1], it doesn't anymore and we have to be explicit.

[1] https://code.launchpad.net/~jonas-drange/ubuntu-system-settings/hwKeyboardMinimal/+merge/281213

To post a comment you must log in.
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2155
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/766/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/1007
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1023
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/1023
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1021/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/1021/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1021/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/1021/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1021/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/1021/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/766/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~unity-team/unity8/oobe-set-osk updated
2156. By Michael Terry

Add mock keyboard plugin

Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2156
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/770/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/1011
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1027
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/1027
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1025/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/1025/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1025/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/1025/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1025/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/1025/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/770/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Lukáš Tinkl (lukas-kde) wrote :

* Did you perform an exploratory manual test run of the code change and any related functionality?

Yes, works fine, OSK enabled and in the correct language

* Did CI run pass? If not, please explain why.

No, insufficent Build-Deps, resolved in main branch since then

* Did you make sure that the branch does not contain spurious tags?

Yes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches