Merge lp://staging/~unity-api-team/indicator-power/lp-1370791-15.05-adjust-slider-when-brightness-is-changed-by-powerd into lp://staging/indicator-power/15.04

Proposed by Charles Kerr
Status: Merged
Approved by: Alejandro J. Cura
Approved revision: 289
Merged at revision: 287
Proposed branch: lp://staging/~unity-api-team/indicator-power/lp-1370791-15.05-adjust-slider-when-brightness-is-changed-by-powerd
Merge into: lp://staging/indicator-power/15.04
Diff against target: 339 lines (+186/-70)
3 files modified
src/CMakeLists.txt (+4/-0)
src/brightness.c (+98/-70)
src/com.canonical.powerd.xml (+84/-0)
To merge this branch: bzr merge lp://staging/~unity-api-team/indicator-power/lp-1370791-15.05-adjust-slider-when-brightness-is-changed-by-powerd
Reviewer Review Type Date Requested Status
Alejandro J. Cura (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+259676@code.staging.launchpad.net

Commit message

When in autobrightness mode, keep the brightness slider's value in sync with the system brightness

Description of the change

== Description of the Change

In the brightness code, add a powerd proxy that listens to property changes from the com.canonical.powerd.Brightness property. When this changes, update the indicator's power slider to reflect the change.

== Checklist

* Are there any related MPs required for this MP to build/function as expected? Please list.

Yes, https://code.launchpad.net/~charlesk/powerd/lp-1370791-add-brightness-property is required to publish powerd's brightness changes on the bus.

> * Is your branch in sync with latest trunk? (e.g. bzr pull lp:trunk -> no changes)

Targeted for lp:indicator-power/15.04. bzr pull lp:indicator-power/15.04 -> no changes

> * Did the code build without warnings?

Yes

> * Did the tests run successfully?

Yes

> * Did you perform an exploratory manual test run of your code change and any related functionality?

Yes

> * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

N/A

> * Did your component test plan pass? If on a device, what image number?

Yes mako wily r202

> * Please list which manual tests are germane for the reviewer in this MR.

indicator-power/device-brightness-slider-auto and
indicator-power/device-brightness-slider

> Did you provide a link to this page https://wiki.ubuntu.com/Process/Merges/Checklists/indicator-power

Yes

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alejandro J. Cura (alecu) wrote :

== Reviewer Checklist

* Have you checked that the submitter has accurately filled out the submitter checklist and has taken no shortcuts?

Yes, checked.

* Did you run the manual tests listed by the submitter?

I followed both manual tests, everything seems to work ok.

* Did you do exploratory testing related to the component you own with the MP changeset included?

I did exploratory testing around the new feature, checking the slider with sunlight, flashlight, darkened indoors and covering the sensor. It all seems to work just fine.

* If new features have been added, are the manual tests sufficient to cover them?

The manual tests added to the test plan seem to cover all new features in this MP.

---

Code looks good, and manual testing works as expected.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches