Unity HUD

Merge lp://staging/~unity-api-team/hud/null-guard-itemstore into lp://staging/hud/14.04

  1. null-guard-itemstore
  2. Merge into trunk.14.04
Proposed by Pete Woods
Status: Superseded
Proposed branch: lp://staging/~unity-api-team/hud/null-guard-itemstore
Merge into: lp://staging/hud/14.04
Diff against target: 59 lines (+31/-2)
2 files modified
service/ItemStore.cpp (+10/-2)
tests/unit/service/TestItemStore.cpp (+21/-0)
To merge this branch: bzr merge lp://staging/~unity-api-team/hud/null-guard-itemstore
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+211478@code.staging.launchpad.net

This proposal has been superseded by a proposal from 2014-03-20.

Commit message

Add null guards to ItemStore search

Description of the change

Add null guards to ItemStore search

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:382
http://jenkins.qa.ubuntu.com/job/hud-ci/260/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/hud-trusty-amd64-ci/111
    SUCCESS: http://jenkins.qa.ubuntu.com/job/hud-trusty-armhf-ci/110
    SUCCESS: http://jenkins.qa.ubuntu.com/job/hud-trusty-i386-ci/110

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/hud-ci/260/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:383
http://jenkins.qa.ubuntu.com/job/hud-ci/261/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/hud-trusty-amd64-ci/112
    SUCCESS: http://jenkins.qa.ubuntu.com/job/hud-trusty-armhf-ci/111
    SUCCESS: http://jenkins.qa.ubuntu.com/job/hud-trusty-i386-ci/111

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/hud-ci/261/rebuild

review: Approve (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) wrote :

LGTM.

review: Approve
lp://staging/~unity-api-team/hud/null-guard-itemstore updated
384. By Pete Woods

Add test for deleted item search

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches