Merge lp://staging/~ueqa-projects-team/ubuntu-system-settings/minimal-sim-pin-helpers into lp://staging/ubuntu-system-settings
Proposed by
Allan LeSage
| Status: | Merged |
|---|---|
| Approved by: | Ken VanDine |
| Approved revision: | 1224 |
| Merged at revision: | 1251 |
| Proposed branch: | lp://staging/~ueqa-projects-team/ubuntu-system-settings/minimal-sim-pin-helpers |
| Merge into: | lp://staging/ubuntu-system-settings |
| Diff against target: |
75 lines (+54/-0) 2 files modified
plugins/security-privacy/SimPin.qml (+1/-0) tests/autopilot/ubuntu_system_settings/__init__.py (+53/-0) |
| To merge this branch: | bzr merge lp://staging/~ueqa-projects-team/ubuntu-system-settings/minimal-sim-pin-helpers |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot | continuous-integration | Needs Fixing | |
| Leo Arias (community) | Approve | ||
| Ken VanDine | Pending | ||
|
Review via email:
|
|||
Commit message
Minimal helpers for a SIM PIN test.
Description of the change
Minimal helpers for a SIM PIN test which will live in UEQA's sanity suite.
To post a comment you must log in.
Revision history for this message
| Leo Arias (elopio) wrote | # |
Revision history for this message
| Leo Arias (elopio) | # |
review:
Approve
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
33 + def _go_to_
51 + def _click_
They are not called from anywhere inside this branch, I'd say they should be public.
67 + keyboard = Keyboard.create()
68 + keyboard.type(pin)
This doesn't look good. If the field you are filling is a text field, you can use the toolkit helper calling the write method.
if it extends text field, then you need to make a CPO for it that extends from the text field cpo.