ubuntu-system-settings

Merge lp://staging/~ueqa-projects-team/ubuntu-system-settings/bluetooth-page-autopilot-helpers-minus-less-flaky into lp://staging/ubuntu-system-settings

  1. bluetooth-page-autopilot-helpers-minus-less-flaky
  2. Merge into trunk
Proposed by Allan LeSage
Status: Superseded
Proposed branch: lp://staging/~ueqa-projects-team/ubuntu-system-settings/bluetooth-page-autopilot-helpers-minus-less-flaky
Merge into: lp://staging/ubuntu-system-settings
Diff against target: 1559 lines (+358/-292)
14 files modified
plugins/bluetooth/PageComponent.qml (+3/-0)
tests/autopilot/ubuntu_system_settings/__init__.py (+71/-27)
tests/autopilot/ubuntu_system_settings/tests/__init__.py (+54/-67)
tests/autopilot/ubuntu_system_settings/tests/test_about.py (+10/-15)
tests/autopilot/ubuntu_system_settings/tests/test_background.py (+5/-5)
tests/autopilot/ubuntu_system_settings/tests/test_datetime.py (+19/-24)
tests/autopilot/ubuntu_system_settings/tests/test_main.py (+4/-4)
tests/autopilot/ubuntu_system_settings/tests/test_phone.py (+3/-20)
tests/autopilot/ubuntu_system_settings/tests/test_phone_sound.py (+32/-0)
tests/autopilot/ubuntu_system_settings/tests/test_plugins.py (+18/-18)
tests/autopilot/ubuntu_system_settings/tests/test_search.py (+4/-4)
tests/autopilot/ubuntu_system_settings/tests/test_security.py (+88/-67)
tests/autopilot/ubuntu_system_settings/tests/test_sound.py (+40/-34)
tests/autopilot/ubuntu_system_settings/tests/test_wifi.py (+7/-7)
To merge this branch: bzr merge lp://staging/~ueqa-projects-team/ubuntu-system-settings/bluetooth-page-autopilot-helpers-minus-less-flaky
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Leo Arias (community) Approve
Ubuntu Touch System Settings Pending
Christopher Lee Pending
Review via email: mp+244248@code.staging.launchpad.net

This proposal supersedes a proposal from 2014-12-05.

This proposal has been superseded by a proposal from 2014-12-12.

Commit message

Minimal set of bluetooth page helpers for external UEQA sanity test.

Description of the change

Add just a few helpers for a Bluetooth sanity test. Note that this MP doesn't require Ken's 'less-flaky' branch as a prereq.

To post a comment you must log in.
Revision history for this message
Christopher Lee (veebers) wrote : Posted in a previous version of this proposal

A couple of questions, otherwise seems good.

review: Needs Information
Revision history for this message
Leo Arias (elopio) wrote : Posted in a previous version of this proposal

Leaving my approval, with just one suggestion below.

review: Approve
Revision history for this message
Allan LeSage (allanlesage) wrote : Posted in a previous version of this proposal

I think Leo answered Chris' need for info, I've implemented the requested changes, switching this to 'needs review'.

Revision history for this message
Leo Arias (elopio) wrote :

59 + def get_disconnected_list(self):

Please rename this to get_disconnected_devices

lp://staging/~ueqa-projects-team/ubuntu-system-settings/bluetooth-page-autopilot-helpers-minus-less-flaky updated
1224. By Allan LeSage

Change a helper function name.

Revision history for this message
Leo Arias (elopio) :
review: Approve
lp://staging/~ueqa-projects-team/ubuntu-system-settings/bluetooth-page-autopilot-helpers-minus-less-flaky updated
1225. By Allan LeSage

Merge less_flaky, resolving conflict.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1223
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/1845/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/512
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-vivid-i386-ci/115
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/445
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/510
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/510/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/16494

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1845/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1225
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/1849/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/516/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-vivid-i386-ci/119
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/449/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/514
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/514/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/16498

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1849/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1225
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/1851/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/531
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-vivid-i386-ci/121
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/463
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/529
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/529/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/16515

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1851/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~ueqa-projects-team/ubuntu-system-settings/bluetooth-page-autopilot-helpers-minus-less-flaky updated
1226. By Allan LeSage

Merge trunk, resolving conflict.

1227. By Allan LeSage

Merge less_flaky, resolving conflict.

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches