Ubuntu Weather App

Merge lp://staging/~ubuntu-weather-dev/ubuntu-weather-app/reboot-finish-listitem-migration into lp://staging/ubuntu-weather-app

  1. reboot-finish-listitem-migration
  2. Merge into reboot
Proposed by Victor Thompson
Status: Needs review
Proposed branch: lp://staging/~ubuntu-weather-dev/ubuntu-weather-app/reboot-finish-listitem-migration
Merge into: lp://staging/ubuntu-weather-app
Prerequisite: lp://staging/~ahayzen/ubuntu-weather-app/reboot-uc1.3-bump
Diff against target: 1236 lines (+98/-948)
13 files modified
app/components/CMakeLists.txt (+0/-2)
app/components/ListItemActions/CMakeLists.txt (+0/-5)
app/components/ListItemActions/CheckBox.qml (+0/-25)
app/components/ListItemActions/Remove.qml (+0/-27)
app/components/ListItemReorderComponent.qml (+0/-106)
app/components/ListItemWithActions.qml (+0/-496)
app/components/MultiSelectHeadState.qml (+0/-72)
app/components/MultiSelectListView.qml (+27/-8)
app/components/WeatherListItem.qml (+0/-138)
app/components/WeatherListView.qml (+1/-2)
app/ui/LocationsPage.qml (+63/-48)
debian/changelog (+4/-0)
po/com.ubuntu.weather.pot (+3/-19)
To merge this branch: bzr merge lp://staging/~ubuntu-weather-dev/ubuntu-weather-app/reboot-finish-listitem-migration
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Approve
Andrew Hayzen Pending
Ubuntu Phone Apps Jenkins Bot continuous-integration Pending
Review via email: mp+278209@code.staging.launchpad.net

This proposal supersedes a proposal from 2015-08-05.

Commit message

* Finish the migration to the new SDK list items
* Lock weather app in the Portrait orientation until we get some landscape designs
* Make the page with bottom edge animation less jarring when it reaches the top by adding a fake header (similar to what the clock app does)

Description of the change

* Finished the migration to the new SDK list items
* Locked weather app in the Portrait orientation until we get some landscape designs
* Made the page with bottom edge animation less jarring when it reaches the top by adding a fake header (similar to what the clock app does)
* Buy nik90 a beer for starting this effort

To post a comment you must log in.
Revision history for this message
Victor Thompson (vthompson) wrote : Posted in a previous version of this proposal

The original MP is here, for reference for remaining issues: https://code.launchpad.net/~nik90/ubuntu-weather-app/finish-listitem-migration/+merge/263136

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:70
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/174/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-utopic-amd64-ci/144
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-vivid-amd64-ci/174

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/174/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote : Posted in a previous version of this proposal

A few inline comments, visually ...
1) there appears to be a space between the detected location and the first selected location
2) if you multiselect, select an item, then select delete you are still in multiselect mode, this is weird if you remove the last item in the list as you have to hit back what feels like twice. I suggest when delete is pressed in the header that the multiselect mode is cancelled.

review: Needs Fixing
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:71
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/208/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-utopic-amd64-ci/178/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-vivid-amd64-ci/208/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/208/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Victor Thompson (vthompson) wrote : Posted in a previous version of this proposal

> Should this have // CUSTOM as a note incase we do a pull of upstream and miss that we made changes?
Sure. I added a comment. I think eventually this will be folded into the SDK anyway. They already pulled in a hint component that we should make use of soonish.

> Why was this changed it looks the same just with { } around it?
No reason that I know of. I didn't like it either when I was resolving merge conflicts. Updated.

> Not A->Z
Fixed.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:72
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/209/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-utopic-amd64-ci/179/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-vivid-amd64-ci/209/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/209/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:73
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/221/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-utopic-amd64-ci/191
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-vivid-amd64-ci/221

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/221/rebuild

review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:74
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/238/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-utopic-amd64-ci/208
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-vivid-amd64-ci/238

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/238/rebuild

review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:76
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/254/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-utopic-amd64-ci/224
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-vivid-amd64-ci/254

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/254/rebuild

review: Approve (continuous-integration)
Revision history for this message
Victor Thompson (vthompson) wrote : Posted in a previous version of this proposal

I've been testing this branch a bit. I think many of the list item blockers have been fixed. To aide in testing, could we get a comprehensive list of bugs that we should verify have been fixed?

Revision history for this message
Andrew Hayzen (ahayzen) wrote : Posted in a previous version of this proposal

Its the same set of bugs that are blocking the music one [0]

bug 1469471 (causes checkbox to not update in selectMode)
bug 1468100 (swiping can break selectMode)
bug 1486008 (swipe remove button is too small on mako)

IIRC it was only the last bug that was not fixed, which I think is now fixed in rc-proposed?

0 - https://code.launchpad.net/~ahayzen/music-app/refactor-use-sdk-listitems/+merge/261328

Revision history for this message
Victor Thompson (vthompson) wrote : Posted in a previous version of this proposal

Agreed, bug 1486008 appears to be fixed in rc-proposed.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:77
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/278/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-vivid-amd64-ci/278

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/278/rebuild

review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:79
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/279/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-vivid-amd64-ci/279

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/279/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote : Posted in a previous version of this proposal

We will need to bump to uc1.3 for this as well, I'll make a branch that this can rebase onto.

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:79
https://core-apps-jenkins.ubuntu.com/job/weather-app-ci/7/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/61/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/weather-app-ci/7/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:80
https://core-apps-jenkins.ubuntu.com/job/weather-app-ci/19/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/164/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/weather-app-ci/19/rebuild

review: Approve (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:80
https://core-apps-jenkins.ubuntu.com/job/weather-app-ci/20/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/165/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/weather-app-ci/20/rebuild

review: Approve (continuous-integration)
Reply
lp://staging/~ubuntu-weather-dev/ubuntu-weather-app/reboot-finish-listitem-migration updated
82. By Victor Thompson

Merge trunk, resolve conflicts, and add changelog entry

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:82
https://core-apps-jenkins.ubuntu.com/job/weather-app-ci/27/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/244/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/weather-app-ci/27/rebuild

review: Approve (continuous-integration)
Reply

Unmerged revisions

82. By Victor Thompson

Merge trunk, resolve conflicts, and add changelog entry

81. By Victor Thompson

rebase on UC1.3 branch

80. By Victor Thompson

Merge of trunk

79. By Victor Thompson

Fix pot file

78. By Victor Thompson

Removed bad FakeHeader

77. By Victor Thompson

Merge of trunk and resolve conflicts.

76. By Victor Thompson

fix bad conflict resolution

75. By Victor Thompson

Merge and resolve conflicts.

74. By Victor Thompson

Merge of trunk

73. By Victor Thompson

Merge and resolve conflicts

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches