Merge lp://staging/~ubuntu-treblig/ubuntu/precise/procps/fix-for-bug-965341 into lp://staging/ubuntu/precise/procps

Proposed by Dave Gilbert
Status: Needs review
Proposed branch: lp://staging/~ubuntu-treblig/ubuntu/precise/procps/fix-for-bug-965341
Merge into: lp://staging/ubuntu/precise/procps
Diff against target: 95 lines (+37/-1)
6 files modified
.pc/applied-patches (+2/-0)
debian/changelog (+7/-0)
debian/patches/series (+2/-0)
debian/patches/widecharseg.patch (+22/-0)
skill.c (+2/-0)
watch.c (+2/-1)
To merge this branch: bzr merge lp://staging/~ubuntu-treblig/ubuntu/precise/procps/fix-for-bug-965341
Reviewer Review Type Date Requested Status
Colin Watson Pending
Review via email: mp+100347@code.staging.launchpad.net

Description of the change

Fix for bug 965341 - a seg caused by watch passing a wide char to isprint; replace with call to iswprint
which seems to be the sanest thing to do (see discussion http://irclogs.ubuntu.com/2012/04/01/%23ubuntu-devel.html )
Checked it doesn't seg in the original case, also did a watch of a tail on a Korean (?) doc and looks the same (not that I know Korean, but the snapshot looks the same, not sure if it hit this code).

To post a comment you must log in.
62. By Dave Gilbert

skill.c: Fix seg when no parameter to -s (LP: #432861)

Unmerged revisions

62. By Dave Gilbert

skill.c: Fix seg when no parameter to -s (LP: #432861)

61. By Dave Gilbert

watch.c: Fix seg caused by passing isprint a wide character. (LP: #965341)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: