Merge lp://staging/~ubuntu-sdk-team/ubuntu-ui-toolkit/spaceTriggerButton into lp://staging/ubuntu-ui-toolkit/staging
Proposed by
Cris Dywan
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Zsombor Egri | ||||
| Approved revision: | 1747 | ||||
| Merged at revision: | 1756 | ||||
| Proposed branch: | lp://staging/~ubuntu-sdk-team/ubuntu-ui-toolkit/spaceTriggerButton | ||||
| Merge into: | lp://staging/ubuntu-ui-toolkit/staging | ||||
| Diff against target: |
66 lines (+23/-3) 3 files modified
src/Ubuntu/Components/plugin/ucabstractbutton.cpp (+2/-3) src/Ubuntu/Components/plugin/ucactionitem.cpp (+1/-0) tests/unit_x11/tst_components/tst_focus.qml (+20/-0) |
||||
| To merge this branch: | bzr merge lp://staging/~ubuntu-sdk-team/ubuntu-ui-toolkit/spaceTriggerButton | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot | continuous-integration | Approve | |
| Zsombor Egri | Approve | ||
|
Review via email:
|
|||
Commit message
Enter/Return/Space should trigger() Button
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
One small thing inline. It's pretty crap that moc compiler doesn't warn you when emit on a slot.