Ubuntu UI Toolkit

Merge lp://staging/~ubuntu-sdk-team/ubuntu-ui-toolkit/inputFlickableContentWidth into lp://staging/ubuntu-ui-toolkit/staging

  1. inputFlickableContentWidth
  2. Merge into staging
Proposed by Cris Dywan
Status: Work in progress
Proposed branch: lp://staging/~ubuntu-sdk-team/ubuntu-ui-toolkit/inputFlickableContentWidth
Merge into: lp://staging/ubuntu-ui-toolkit/staging
Diff against target: 174 lines (+64/-57)
3 files modified
examples/ubuntu-ui-toolkit-gallery/TextInputs.qml (+12/-0)
src/Ubuntu/Components/1.3/InputHandler.qml (+6/-5)
src/Ubuntu/Components/1.3/TextField.qml (+46/-52)
To merge this branch: bzr merge lp://staging/~ubuntu-sdk-team/ubuntu-ui-toolkit/inputFlickableContentWidth
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu SDK team Pending
Review via email: mp+275888@code.staging.launchpad.net

Commit message

InputHandler.ensureVisible needs to take flickable contentWidth into account

Description of the change

InputHandler.ensureVisible needs to take flickable contentWidth into account

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1695
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2432/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/1160
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/1162
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/1162/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/1159

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2432/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Cris Dywan (kalikiana) wrote :

Validation of the state of this MR:

r1694 slightly improves the problem but effectively hides the handlers and moves them offscreen. It can suffer from a binding race where handlers move offscreen in a non-recoverable way.
r1695 removes the Flickable - in theory it simplifies and improves scrolling, in practise it still suffers from the same binding race.
^^ For reference the diff suffers less visibly from the binding race, but it also doesn't improve much on the bug, and the handlers remain largely offscreen as before.

Reply

Unmerged revisions

1695. By Cris Dywan

Scrollable TextField without Flickable

1694. By Cris Dywan

InputHandler.ensureVisible needs to take flickable contentWidth into account

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches