Ubuntu UI Toolkit

Merge lp://staging/~ubuntu-sdk-team/ubuntu-ui-toolkit/imageSourceNotNOTIFYable into lp://staging/ubuntu-ui-toolkit/staging

imageSourceNotNOTIFYable
Merge into staging

Proposed by Cris Dywan on 2014-11-24

Status:

Merged

Approved by:

Zoltan Balogh on 2014-11-24

Approved revision:

1343

Merged at revision:

1341

Proposed branch:

lp://staging/~ubuntu-sdk-team/ubuntu-ui-toolkit/imageSourceNotNOTIFYable

Merge into:

lp://staging/ubuntu-ui-toolkit/staging

Diff against target:

102 lines (+35/-6)

4 files modified

components.api (+2/-0)
modules/Ubuntu/Components/plugin/ucqquickimageextension.cpp (+3/-0)
modules/Ubuntu/Components/plugin/ucqquickimageextension.h (+4/-1)
tests/unit_x11/tst_components/tst_imageprovider.qml (+26/-5)

To merge this branch:

bzr merge lp://staging/~ubuntu-sdk-team/ubuntu-ui-toolkit/imageSourceNotNOTIFYable

Related bugs:

Bug #1395690: importing Ubuntu.Components makes Image source property non notify-able	Critical	Fix Released
Bug #1395793: Icons missing in ListItems widgets	High	Fix Released

Link a bug report

Reviewer	Review Type	Status
PS Jenkins bot	continuous-integration	Approve on 2014-11-24
Cris Dywan		Approve on 2014-11-24
Review via email: mp+242655@code.staging.launchpad.net

Commit message

Re-introduce NOTIFY to Image under a different name

Description of the change

Re-introduce NOTIFY to Image under a different name

Revision history for this message

Cris Dywan (kalikiana) wrote on 2014-11-24:

In theory I like the approach; unfortunately I can't build the branch right now and I don't know why. If Jenkins can run the tests successfully I'll finish my review.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-11-24:

FAILED: Continuous integration, rev:1342
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/imageSourceNotNOTIFYable/+merge/242655/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1260/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/6612/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-amd64-ci/1093/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-ci/1092/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-i386-ci/1092/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7864/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1260/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-11-24:

FAILED: Continuous integration, rev:1343
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/imageSourceNotNOTIFYable/+merge/242655/+edit-commit-message

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1263/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-11-24:

FAILED: Autolanding.
No commit message was specified in the merge proposal. Hit 'Add commit message' on the merge proposal web page or follow the link below. You can approve the merge proposal yourself to rerun.
https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/imageSourceNotNOTIFYable/+merge/242655/+edit-commit-message