Merge ~ubuntu-core-dev/shim/+git/shim-signed:sil2100/use-auto-nvram into ~ubuntu-core-dev/shim/+git/shim-signed:master

Proposed by Łukasz Zemczak
Status: Merged
Approved by: Mathieu Trudel-Lapierre
Approved revision: 6a7f965980d4136d6ce3d9a6d787457dee5aae81
Merged at revision: 247566a8bf18426714ba1584995dc9a415df6174
Proposed branch: ~ubuntu-core-dev/shim/+git/shim-signed:sil2100/use-auto-nvram
Merge into: ~ubuntu-core-dev/shim/+git/shim-signed:master
Diff against target: 45 lines (+13/-2)
3 files modified
debian/changelog (+11/-0)
debian/control (+1/-1)
debian/shim-signed.postinst (+1/-1)
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Approve
Review via email: mp+345339@code.staging.launchpad.net

Commit message

debian/shim-signed.postinst: use --auto-nvram with grub-install in case we're installing on a NVRAM-unavailable platform.

Description of the change

debian/shim-signed.postinst: use --auto-nvram with grub-install in case we're installing on a NVRAM-unavailable platform.

This change still needs some testing. Also, should the check for /boot/efi/EFI/$bootloader_id be removed as well?

To post a comment you must log in.
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Looks good to me. There may still be places that run grub-install (grub-installer? curtin?) that will need to be updated, but at least this will cover upgrades.

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches