shim

Merge ~ubuntu-core-dev/shim/+git/shim-signed:self-signed into ~ubuntu-core-dev/shim/+git/shim-signed:master

  1. Git
  2. lp:~ubuntu-core-dev/shim/+git/shim-signed
  3. self-signed
  4. Merge into master
Proposed by Mathieu Trudel-Lapierre
Status: Merged
Merged at revision: 51d2be9876e8ce47a7bd0fdb0c4e68427cce9cdd
Proposed branch: ~ubuntu-core-dev/shim/+git/shim-signed:self-signed
Merge into: ~ubuntu-core-dev/shim/+git/shim-signed:master
Diff against target: 570 lines (+320/-140)
7 files modified
debian/changelog (+33/-0)
debian/shim-signed.dirs (+1/-0)
debian/shim-signed.install (+1/-0)
debian/shim-signed.postinst (+24/-2)
debian/templates (+20/-23)
openssl.cnf (+27/-0)
update-secureboot-policy (+214/-115)
Reviewer Review Type Date Requested Status
Steve Langasek Approve
Adam Conrad (community) Needs Fixing
Review via email: mp+337571@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Adam Conrad (adconrad) wrote :

Some initial thoughts inline in the code. I haven't reviewed the meat of the update-sb-policy code changes yet, as that's an eye-crossing endeavour that requires coffee, but I'm less concerned about finding shell bugs than I am about overall behaviour, design, and upgrade sanity.

review: Needs Fixing
Revision history for this message
Steve Langasek (vorlon) wrote :

Thanks, comments inline. This includes some tweaks to the existing debconf template language - sorry about that - but I think we should get it cleaned up all at the same time while landing this.

Review summary: there are several serious bugs in the current version. Please resubmit for review when fixed.

review: Needs Fixing
Revision history for this message
Steve Langasek (vorlon) :
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Will fix the stuff identified.

Revision history for this message
Steve Langasek (vorlon) :
Revision history for this message
Steve Langasek (vorlon) wrote :

Thanks, this looks very solid. Only a few minor comments inline.

review: Needs Fixing
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) :
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) :
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) :
Revision history for this message
Steve Langasek (vorlon) :
Revision history for this message
Steve Langasek (vorlon) :
review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches