Merge ~ua-apps-devs/+git/ust:fix-build into ~ua-apps-devs/+git/ust:master

Proposed by Lucas Kanashiro
Status: Needs review
Proposed branch: ~ua-apps-devs/+git/ust:fix-build
Merge into: ~ua-apps-devs/+git/ust:master
Diff against target: 137 lines (+96/-14)
4 files modified
debian/changelog (+12/-0)
debian/patches/series (+1/-1)
debian/patches/use-javac-to-generate-jni-headers.patch (+83/-0)
dev/null (+0/-13)
Reviewer Review Type Date Requested Status
Bryce Harrington Approve
Review via email: mp+377402@code.staging.launchpad.net

Description of the change

The current ust version in bionic FTBFS because it relies on javah which is not available in JDK 11 (the default JDK in bionic). The proposed patch changes some Makefiles to use javac instead of javah to generate JNI native headers.

To post a comment you must log in.
Revision history for this message
Bryce Harrington (bryce) wrote :

LGTM, +1

I had to read up on AM_JAVACFLAGS (https://ftp.gnu.org/old-gnu/Manuals/automake-1.6.1/html_node/automake_58.html)

Can you upload it to your PPA, as verification it builds? I can pull the .dsc from there and upload to the staging ppa.

review: Approve
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: