Juju Charms Collection
swift-proxy package

Merge lp://staging/~tyomogita/charms/precise/swift-proxy/fix-lp1087142 into lp://staging/~charmers/charms/precise/swift-proxy/trunk

Proposed by Toshiyuki YOMOGITA on 2012-12-06

Status:

Rejected

Rejected by:

Adam Gandelman on 2012-12-06

Proposed branch:

lp://staging/~tyomogita/charms/precise/swift-proxy/fix-lp1087142

Merge into:

lp://staging/~charmers/charms/precise/swift-proxy/trunk

Diff against target:

14 lines (+3/-1)

1 file modified

hooks/swift-proxy-relations (+3/-1)

To merge this branch:

bzr merge lp://staging/~tyomogita/charms/precise/swift-proxy/fix-lp1087142

Undecided

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Adam Gandelman (community)		2012-12-06	Disapprove on 2012-12-06
Review via email: mp+138416@code.staging.launchpad.net

Description of the change

Current charms of swift-proxy and swift-storage remove all contents in /etc/apt/apt.conf.
So squid-deb-proxy in MAAS won't be used.

So using exsiting /etc/apt/apt.conf as possible.

For example:

/etc/apt/apt.conf
Acquire::http::Proxy "http://<MAAS>:8000/";

/etc/apt/apt.conf.d/99cloud-archive
Acquire::http::Proxy::ubuntu-cloud.archive.canonical.com "DIRECT";

Revision history for this message

Adam Gandelman (gandelman-a) wrote on 2012-12-06:

Toshiyuki-

I think the best solution here is to migrate the swift charms to start using the common Openstack charm code we've been syncing between the rest of the Openstack charms (see nova-cloud-controller). The code there allows us to handle repository setup more generically. I think if we want to start messing with Ubuntu Cloud Archive-specific apt.conf settings, thats where it should happen. Updating swift to use that stuff is long overdue. I'll put up a merge proposal to do that, and perhaps you can rebase this against that.

review: Disapprove

Unmerged revisions

32. By Toshiyuki YOMOGITA on 2012-12-06: use exsiting /etc/apt/apt.conf as possible, but connect to the Ubuntu
Cloud Archive directly for MAAS (LP: #1087142)