eCryptfs

Merge lp://staging/~tyhicks/ecryptfs/fix-most-Wall-and-Wextra-warnings into lp://staging/ecryptfs

fix-most-Wall-and-Wextra-warnings
Merge into trunk

Proposed by Tyler Hicks on 2013-10-28

Status:	Merged
Merged at revision:	814
Proposed branch:	lp://staging/~tyhicks/ecryptfs/fix-most-Wall-and-Wextra-warnings
Merge into:	lp://staging/ecryptfs
Diff against target:	615 lines (+103/-104) 17 files modified src/libecryptfs/ecryptfs-stat.c (+1/-1) src/libecryptfs/key_management.c (+0/-1) src/libecryptfs/miscdev.c (+1/-1) src/libecryptfs/module_mgr.c (+60/-39) src/pam_ecryptfs/pam_ecryptfs.c (+0/-31) src/utils/mount.ecryptfs.c (+1/-0) src/utils/mount.ecryptfs_private.c (+10/-7) src/utils/test.c (+6/-6) tests/kernel/directory-concurrent/test.c (+1/-1) tests/kernel/enospc/test.c (+0/-1) tests/kernel/extend-file-random/test.c (+16/-2) tests/kernel/file-concurrent/test.c (+1/-1) tests/kernel/inode-race-stat/test.c (+2/-3) tests/kernel/inotify/test.c (+1/-1) tests/kernel/lp-509180/test.c (+0/-1) tests/kernel/trunc-file/test.c (+2/-7) tests/userspace/wrap-unwrap/test.c (+1/-1)
To merge this branch:	bzr merge lp://staging/~tyhicks/ecryptfs/fix-most-Wall-and-Wextra-warnings
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Colin Ian King (community)		2013-10-28	Approve on 2013-10-28
Review via email: mp+192913@code.staging.launchpad.net

Description of the change

This is a good start towards fixing all warnings emitted when building with
the output of Saucy's `dpkg-buildflags --dump` plus '-Wall -Wextra' on amd64,
i386, and armhf.

I want to have a quiet, warning-free build so that we can use the compiler to
help a little more with catching bugs in new commits. I don't want to go as far
as enabling -Werror by default, but it'd be nice to have the option of using it
locally when developing/testing/reviewing new commits.

What's left is:

[-Wmissing-field-initializers]
[-Wunused-parameter]
[-Wunused-result]

I'll fix those remaining three very soon. I just didn't get to them before
Monday rolled around.

Revision history for this message

Tyler Hicks (tyhicks) wrote on 2013-10-28:

Note that the "Unmerged revisions" section below isn't showing all of the revisions. It is missing the descriptions for r800 through r804. I'm sure you can look at the proposed branch, but here's a quick paste of those revision descriptions:

------------------------------------------------------------
revno: 804
  Fix some of the signed and unsigned int comparisons (-Wsign-compare)
------------------------------------------------------------
revno: 803
  Fix -Wempty-body warning
------------------------------------------------------------
revno: 802
  Remove the unused 'order' member of the supported_key_bytes struct
------------------------------------------------------------
revno: 801
  Fix sign comparison warnings and other issues surrounding the uint32_t type
  used for key_bytes
------------------------------------------------------------
revno: 800
  Fix 'unused variable' warnings
------------------------------------------------------------