Additional payment, bank statement and voucher addons for OpenERP

Merge lp://staging/~txerpa/account-payment/7.0-account_payment-call-move-post into lp://staging/~account-payment-team/account-payment/7.0

7.0-account_payment-call-move-post
Merge into 7.0

Proposed by Biel - txerpa.com on 2013-12-10

Status:	Merged
Merged at revision:	108
Proposed branch:	lp://staging/~txerpa/account-payment/7.0-account_payment-call-move-post
Merge into:	lp://staging/~account-payment-team/account-payment/7.0
Diff against target:	13 lines (+1/-3) 1 file modified account_payment_extension/account_payment.py (+1/-3)
To merge this branch:	bzr merge lp://staging/~txerpa/account-payment/7.0-account_payment-call-move-post
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Pedro Manuel Baeza		2013-12-10	Approve on 2014-01-31
Omar (Pexego)	code review		Needs Fixing on 2013-12-13
xavi (community)			Approve on 2013-12-11
Review via email: mp+198433@code.staging.launchpad.net

Description of the change

When creating an order with the direct payment option and the entry_posted option of the journal is chosen, it changes the status to posted of the move when it should call the post method.

http://bazaar.launchpad.net/~account-payment-team/account-payment/7.0/view/head:/account_payment_extension/account_payment.py#L317

# Post the move
if order.mode.journal.entry_posted:
     move_obj.write(cr, uid, [move_id], {
        'state':'posted',
        }, context)

It should be:
if order.mode.journal.entry_posted:
move_obj.post()

Revision history for this message

Pedro Manuel Baeza (pedro.baeza) wrote on 2013-12-10:

Thanks for the MP! In 6.1, it has been also changed in revision 111. It would be desirable to put context as a keyword argument (context=context), to avoid incompatibilities if the signature of post method changes.

Regards.

review: Approve (code review and test)

Revision history for this message

xavi (xgilest) on 2013-12-11:

review: Approve

Revision history for this message

Omar (Pexego) (omar7r) wrote on 2013-12-13:

Need fixing status, while don't update it with context=context as Pedro said.

Thanks

review: Needs Fixing (code review)

lp://staging/~txerpa/account-payment/7.0-account_payment-call-move-post updated on 2014-01-31