python-oops-wsgi

Merge lp://staging/~twom/python-oops-wsgi/utf-8-encoding-parameters into lp://staging/python-oops-wsgi

  1. utf-8-encoding-parameters
  2. Merge into trunk
Proposed by Tom Wardill
Status: Merged
Merged at revision: 44
Proposed branch: lp://staging/~twom/python-oops-wsgi/utf-8-encoding-parameters
Merge into: lp://staging/python-oops-wsgi
Diff against target: 81 lines (+45/-3)
2 files modified
oops_wsgi/middleware.py (+16/-2)
oops_wsgi/tests/test_middleware.py (+29/-1)
To merge this branch: bzr merge lp://staging/~twom/python-oops-wsgi/utf-8-encoding-parameters
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+344961@code.staging.launchpad.net

Commit message

UTF-8 encode parameters before attempting to quote

Description of the change

UTF-8 passed to python2 urllib quote() will cause a KeyError, https://bugs.python.org/issue1712522

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) :
review: Needs Fixing
lp://staging/~twom/python-oops-wsgi/utf-8-encoding-parameters updated
45. By Tom Wardill

Guard against unicode/wsgi behaviour

46. By Tom Wardill

Greater than or equal 3

47. By Tom Wardill

Style tweaks

Revision history for this message
Colin Watson (cjwatson) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: