Merge lp://staging/~twom/loggerhead/fix-text-types-python-2 into lp://staging/loggerhead
Proposed by
Tom Wardill
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 502 | ||||
| Proposed branch: | lp://staging/~twom/loggerhead/fix-text-types-python-2 | ||||
| Merge into: | lp://staging/loggerhead | ||||
| Diff against target: |
60 lines (+6/-6) 2 files modified
loggerhead/controllers/view_ui.py (+1/-1) loggerhead/tests/test_controllers.py (+5/-5) |
||||
| To merge this branch: | bzr merge lp://staging/~twom/loggerhead/fix-text-types-python-2 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Colin Watson (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Check that path is a text_type, not str explicitly
Description of the change
In python2, the `path` argument is `unicode`, not `str`.
Check against utils.text_type rather than the string type explicitly.
To post a comment you must log in.
Revision history for this message
| Colin Watson (cjwatson) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
