Merge lp://staging/~twom/launchpad-buildd/include-base-in-digests into lp://staging/launchpad-buildd
Proposed by
Tom Wardill
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~twom/launchpad-buildd/include-base-in-digests |
| Merge into: | lp://staging/launchpad-buildd |
| Diff against target: |
288 lines (+124/-37) 5 files modified
debian/changelog (+6/-0) lpbuildd/oci.py (+37/-17) lpbuildd/target/build_oci.py (+18/-0) lpbuildd/target/tests/test_build_oci.py (+32/-0) lpbuildd/tests/test_oci.py (+31/-20) |
| To merge this branch: | bzr merge lp://staging/~twom/launchpad-buildd/include-base-in-digests |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Thiago F. Pappacena (community) | Approve | ||
| Colin Watson (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Include base OS information in digests.json
Description of the change
For the final push to a registry, we need to tag the image with the base OS that it is built on.
Grab this information from `/etc/os-release` inside the image, parse it and save it to an appropriate place in the digests.json for processing downstream in Launchpad.
This is a breaking change in the format of digests.json, so needs the equivalent LP branch first.
To post a comment you must log in.
Revision history for this message
| Colin Watson (cjwatson) | # |
Revision history for this message
| Colin Watson (cjwatson) | # |
Revision history for this message
| Colin Watson (cjwatson) | # |
review:
Approve
Unmerged revisions
- 424. By Tom Wardill
-
More exception cleanup
- 423. By Tom Wardill
-
Tidy up error handling
- 422. By Tom Wardill
-
Import ordering
- 421. By Tom Wardill
-
Comment fix
- 420. By Tom Wardill
-
Add some debug
- 419. By Tom Wardill
-
Include base in the digests file
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM. Thanks!