charm-k8s-ingress

Merge ~twom/charm-k8s-ingress:correct-default-for-path-route into charm-k8s-ingress:master

  1. Git
  2. lp:~twom/charm-k8s-ingress
  3. correct-default-for-path-route
  4. Merge into master
Proposed by Tom Wardill
Status: Merged
Merge reported by: Tom Haddon
Merged at revision: 444c38c8bd98d0e933b1d6a4e4b08c4ddb04c41f
Proposed branch: ~twom/charm-k8s-ingress:correct-default-for-path-route
Merge into: charm-k8s-ingress:master
Diff against target: 59 lines (+36/-1)
2 files modified
config.yaml (+1/-1)
tests/unit/test_charm.py (+35/-0)
Reviewer Review Type Date Requested Status
Tom Haddon Approve
Review via email: mp+403140@code.staging.launchpad.net

Commit message

Set an empty default and use a fallback

Description of the change

Config is taken before relation data, so we should start with an empty config.

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Tom Haddon (mthaddon) wrote :

Can we have a test that would have failed with the old approach to confirm we don't change this back without understanding the consequences? Thanks.

Revision history for this message
Tom Haddon (mthaddon) wrote :

LGTM, black seems to want to apply some changes, but I'll propose those separately.

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: