Ubuntu Desktop Accomplishments

Merge lp://staging/~tvec623/ubuntu-desktop-accomplishments/20120903-sudoku-accomplishment into lp://staging/ubuntu-desktop-accomplishments

  1. 20120903-sudoku-accomplishment
  2. Merge into trunk
Proposed by Tony Vec
Status: Rejected
Rejected by: Matt Fischer
Proposed branch: lp://staging/~tvec623/ubuntu-desktop-accomplishments/20120903-sudoku-accomplishment
Merge into: lp://staging/ubuntu-desktop-accomplishments
Diff against target: 246 lines (+191/-0)
10 files modified
CATEGORIES (+1/-0)
Changelog (+1/-0)
accomplishments/ubuntu-desktop/en/gaming/sudoku_easy.accomplishment (+13/-0)
accomplishments/ubuntu-desktop/en/gaming/sudoku_hard.accomplishment (+13/-0)
accomplishments/ubuntu-desktop/en/gaming/sudoku_medium.accomplishment (+13/-0)
accomplishments/ubuntu-desktop/en/gaming/sudoku_very_hard.accomplishment (+13/-0)
scripts/ubuntu-desktop/gaming/sudoku_easy.py (+34/-0)
scripts/ubuntu-desktop/gaming/sudoku_hard.py (+34/-0)
scripts/ubuntu-desktop/gaming/sudoku_medium.py (+34/-0)
scripts/ubuntu-desktop/gaming/sudoku_very_hard.py (+35/-0)
To merge this branch: bzr merge lp://staging/~tvec623/ubuntu-desktop-accomplishments/20120903-sudoku-accomplishment
Reviewer Review Type Date Requested Status
Rafał Cieślak Needs Fixing
Matt Fischer Needs Fixing
Review via email: mp+122606@code.staging.launchpad.net

Description of the change

Added: 4 accomplishments: Accomplishment checks if user has completed the four levels in Sudoku.
Fixed: removed Shotwell Accomplishment and improved categories by switching to "Gaming:Sudoku"

To post a comment you must log in.
Revision history for this message
Matt Fischer (mfisch) wrote :

Sorry for the delay. I don't see any shotwell changes here, did you miss them?

review: Needs Fixing
Revision history for this message
Rafał Cieślak (rafalcieslak256) wrote :

Matt, there are no changes needed for the Shotwell accomplishment, Tony meant he fixed the fact that it was needlessly added in his previous MP.
I have reviewed these accomplishments and they seem very fine. The scripts are all correct, and metadata is fine.

One last thing that needs fixing is the category. Currently it's "Gaming:Sudoku", but other accomplishments use "Games:...", and therefore, to maintain consistency, sudoku accomplishments should use "Games:Sudoku".

Thanks for this work, Tony. A future tip: when you need to fix something in a MP, do not create a new branch and a separate MP, please commit changes to the same branch you have used for last MP and push changes there, they will be appended to the very same pending MP. This way we are less likely to miss your changes.

review: Needs Fixing
Revision history for this message
Matt Fischer (mfisch) wrote :

Tony,

Thanks for your work on this. Daniel picked up the code and is merging it in a new MP now and you will still get credit.

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches