Merge lp://staging/~tvec623/ubuntu-desktop-accomplishments/20120827-sudoku-accomplishment into lp://staging/ubuntu-desktop-accomplishments
Proposed by
Tony Vec
| Status: | Rejected |
|---|---|
| Rejected by: | Matt Fischer |
| Proposed branch: | lp://staging/~tvec623/ubuntu-desktop-accomplishments/20120827-sudoku-accomplishment |
| Merge into: | lp://staging/ubuntu-desktop-accomplishments |
| Diff against target: |
309 lines (+244/-0) 12 files modified
CATEGORIES (+1/-0) Changelog (+1/-0) accomplishments/ubuntu-desktop/en/gaming/sudoku_easy.accomplishment (+13/-0) accomplishments/ubuntu-desktop/en/gaming/sudoku_hard.accomplishment (+13/-0) accomplishments/ubuntu-desktop/en/gaming/sudoku_medium.accomplishment (+13/-0) accomplishments/ubuntu-desktop/en/gaming/sudoku_very_hard.accomplishment (+13/-0) accomplishments/ubuntu-desktop/en/multimedia/importshotwell.accomplishment (+18/-0) scripts/ubuntu-desktop/gaming/sudoku_easy.py (+34/-0) scripts/ubuntu-desktop/gaming/sudoku_hard.py (+34/-0) scripts/ubuntu-desktop/gaming/sudoku_medium.py (+34/-0) scripts/ubuntu-desktop/gaming/sudoku_very_hard.py (+35/-0) scripts/ubuntu-desktop/multimedia/importshotwell.py (+35/-0) |
| To merge this branch: | bzr merge lp://staging/~tvec623/ubuntu-desktop-accomplishments/20120827-sudoku-accomplishment |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Rafał Cieślak | Needs Fixing | ||
|
Review via email:
|
|||
Description of the change
Added 4 accomplishments: Accomplishment checks if user has completed the four levels in Sudoku.
To post a comment you must log in.
Revision history for this message
| Matt Fischer (mfisch) wrote | # |
Revision history for this message
| Matt Fischer (mfisch) wrote | # |
Unmerged revisions
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Cool accomplishments! We were definitely lacking these ones. Great thanks for your work on them.
There are two small things that will need fixing before I merge this branch:
* Somehow the importshotwell accomplishment is included in this branch too. I guess that's accidental, as you have proposed a separate branch with them.
* The category your Sudoku accomplishments use is "Gaming". That's correct, but it would be cool if we grouped them to a sub-category withing gaming, named "Sudoku". To do this, you need to set their category to "Gaming:Sudoku".