Merge lp://staging/~tvec623/ubuntu-desktop-accomplishments/20120814_accomp_importshowell into lp://staging/ubuntu-desktop-accomplishments
Proposed by
Tony Vec
| Status: | Rejected |
|---|---|
| Rejected by: | Matt Fischer |
| Proposed branch: | lp://staging/~tvec623/ubuntu-desktop-accomplishments/20120814_accomp_importshowell |
| Merge into: | lp://staging/ubuntu-desktop-accomplishments |
| Diff against target: |
87 lines (+55/-2) 4 files modified
accomplishments/ubuntu-desktop/en/multimedia/importshotwell.accomplishment (+18/-0) accomplishments/ubuntu-desktop/en/multimedia/multimedia-added-music.accomplishment (+1/-1) accomplishments/ubuntu-desktop/en/multimedia/musicinrhythmbox.accomplishment (+1/-1) scripts/ubuntu-desktop/multimedia/importshotwell.py (+35/-0) |
| To merge this branch: | bzr merge lp://staging/~tvec623/ubuntu-desktop-accomplishments/20120814_accomp_importshowell |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Rafał Cieślak | Needs Fixing | ||
|
Review via email:
|
|||
Description of the change
Added: New accomplishment set called importshotwell
Minor Fix: Fixed small typos for clarity in multimedia-
To post a comment you must log in.
Revision history for this message
| Matt Fischer (mfisch) wrote | # |
Revision history for this message
| Matt Fischer (mfisch) wrote | # |
Unmerged revisions
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Great accomplishment, Tony! Thanks for submitting it. I have tested it, and I have two notes for you:
* In the 'steps' field, step 4 is unclear ("Click the icon"). While I know that you meant 'click the icon you are presented with in dash search results' (though it took me some time to guess), I'd suggest to merge this step with the previous one, because it makes an impression that one needs to click some icon /after/ they launch Shotwell. And, after all, the point of this accomplishment is not explaining how to launch an application via dash, but how to get shotwell to manage one's images :-)
* For some reason I am not awarded with this accomplishment even though I have imported photos to Shotwell. The script still exits with code 1... I have done a simple debugging, and it seems that ~/.shotwell directory is not present on my system. Can it be it stores my images DB in some other location? It would be great if you managed to fix this. If you need me to assist you by trying some scripts on my system which misses the ~/.shotwell directory, feel free to get in touch with me at #ubuntu-