python-jujuclient

Merge lp://staging/~tvansteenburgh/python-jujuclient/unset-sigalrm into lp://staging/~hazmat/python-jujuclient/trunk

  1. unset-sigalrm
  2. Merge into trunk
Proposed by Tim Van Steenburgh
Status: Merged
Approved by: Kapil Thangavelu
Approved revision: no longer in the source branch.
Merged at revision: 42
Proposed branch: lp://staging/~tvansteenburgh/python-jujuclient/unset-sigalrm
Merge into: lp://staging/~hazmat/python-jujuclient/trunk
Diff against target: 11 lines (+1/-0)
1 file modified
jujuclient.py (+1/-0)
To merge this branch: bzr merge lp://staging/~tvansteenburgh/python-jujuclient/unset-sigalrm
Reviewer Review Type Date Requested Status
Matt Bruzek (community) Approve
Kapil Thangavelu Pending
Review via email: mp+240610@code.staging.launchpad.net

Description of the change

Unschedule SIGALRM when context manager exits.

To post a comment you must log in.
Revision history for this message
Matt Bruzek (mbruzek) wrote :

I got the "Alarm Clock" message when running bundletester.

I patched my jujuclient.py with this change and it no longer got the "Alarm Clock" error.

+1 LGTM

review: Approve
Revision history for this message
Kapil Thangavelu (hazmat) wrote :

lgtm, thanks

lp://staging/~tvansteenburgh/python-jujuclient/unset-sigalrm updated
42. By Tim Van Steenburgh

merge tvan's unset alarm fix

Revision history for this message
Kapil Thangavelu (hazmat) wrote :

fwiw 0.18.5 released to pypi with this change. ppa builders that aren't on
trunk builds need manual kick offs.

On Thu, Dec 18, 2014 at 7:58 PM, <email address hidden> wrote:
>
> The proposal to merge lp:~tvansteenburgh/python-jujuclient/unset-sigalrm
> into lp:python-jujuclient has been updated.
>
> Status: Approved => Merged
>
> For more details, see:
>
> https://code.launchpad.net/~tvansteenburgh/python-jujuclient/unset-sigalrm/+merge/240610
> --
> You are requested to review the proposed merge of
> lp:~tvansteenburgh/python-jujuclient/unset-sigalrm into
> lp:python-jujuclient.
>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches