python-jujuclient

Merge lp://staging/~tvansteenburgh/python-jujuclient/juju2-fixes into lp://staging/python-jujuclient

  1. juju2-fixes
  2. Merge into trunk
Proposed by Tim Van Steenburgh
Status: Merged
Merged at revision: 77
Proposed branch: lp://staging/~tvansteenburgh/python-jujuclient/juju2-fixes
Merge into: lp://staging/python-jujuclient
Diff against target: 104 lines (+19/-14)
2 files modified
jujuclient.py (+14/-10)
test_jujuclient.py (+5/-4)
To merge this branch: bzr merge lp://staging/~tvansteenburgh/python-jujuclient/juju2-fixes
Reviewer Review Type Date Requested Status
David Britton (community) Approve
Review via email: mp+291182@code.staging.launchpad.net
To post a comment you must log in.
lp://staging/~tvansteenburgh/python-jujuclient/juju2-fixes updated
76. By Tim Van Steenburgh

Fix out-of-order line

Revision history for this message
David Britton (dpb) wrote :

looks good in general

review: Approve
lp://staging/~tvansteenburgh/python-jujuclient/juju2-fixes updated
77. By Tim Van Steenburgh

Remove unnecessary override

Revision history for this message
Tim Van Steenburgh (tvansteenburgh) wrote :

I removed the WaitForNoMachines.run() override as it was unnecessary - an artifact of some earlier testing I was doing.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches