Merge lp://staging/~tvansteenburgh/charms/trusty/mediawiki/fix-tests into lp://staging/charms/trusty/mediawiki
Proposed by
Tim Van Steenburgh
| Status: | Merged |
|---|---|
| Merged at revision: | 83 |
| Proposed branch: | lp://staging/~tvansteenburgh/charms/trusty/mediawiki/fix-tests |
| Merge into: | lp://staging/charms/trusty/mediawiki |
| Diff against target: |
20 lines (+1/-2) 1 file modified
tests/100-deploy (+1/-2) |
| To merge this branch: | bzr merge lp://staging/~tvansteenburgh/charms/trusty/mediawiki/fix-tests |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Charles Butler (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Configure memcached to work w/o ipv6 so tests can run on lxc.
To post a comment you must log in.
Revision history for this message
| Kevin W Monroe (kwmonroe) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Hey Tim, thanks for this update. Your change is super simple and I was able to run the tests successfully. Then I started poking around...
The last 100-deploy test doesn't actually test a login. It "posts" login data to the mediawiki homepage, and then just checks that the <title> has our expected config. There's no form submission going on in that exercise, so it's not really a valid login test. Mediawiki exposes a login api that we could use. Here's an MP for your MP:
https:/
Again, i know you didn't introduce this issue, but if you're gonna call your branch "fix-tests", by golly, let's fix 'em.