Merge lp://staging/~tvansteenburgh/charm-tools/no-symlinks into lp://staging/charm-tools/1.3
Proposed by
Tim Van Steenburgh
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~tvansteenburgh/charm-tools/no-symlinks |
| Merge into: | lp://staging/charm-tools/1.3 |
| Diff against target: |
207 lines (+18/-106) 7 files modified
charmtools/charms.py (+1/-1) charmtools/generators/template.py (+8/-0) charmtools/templates/python/config.yaml (+0/-5) charmtools/templates/python/files/hooks_symlinked/hooks.py (+0/-54) charmtools/templates/python/template.py (+0/-16) tests/test_charm_proof.py (+4/-1) tests_functional/create/test_python_create.py (+5/-29) |
| To merge this branch: | bzr merge lp://staging/~tvansteenburgh/charm-tools/no-symlinks |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Marco Ceppi (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Removes option to created symlinked hooks when creating a new charm, since symlinks don't work on Windows.
Run all tests with `make check`. Test manually with:
. bin/activate
charm create foo /tmp
To post a comment you must log in.
Revision history for this message
| Marco Ceppi (marcoceppi) | # |
review:
Needs Fixing
Revision history for this message
| Marco Ceppi (marcoceppi) | # |
review:
Abstain
Unmerged revisions
- 339. By Tim Van Steenburgh
-
Remove option to symlink hooks when creating charm
- 338. By Tim Van Steenburgh
-
Fix charm-proof email validation
formataddr() will put quotes around a name component that
contains special chars. We need to remove those to accurately
compare against the original maintainer string.Also fixes tests that were broken due to new files in
charmhelpers.core
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM