Merge lp://staging/~ttosttos/eidete/fix-1004294 into lp://staging/eidete

Proposed by ttosttos
Status: Merged
Merged at revision: 73
Proposed branch: lp://staging/~ttosttos/eidete/fix-1004294
Merge into: lp://staging/eidete
Diff against target: 231 lines (+54/-37)
4 files modified
CMakeLists.txt (+1/-0)
data/eidete.desktop (+1/-1)
po/eidete.pot (+44/-36)
src/desktop_launcher.vala (+8/-0)
To merge this branch: bzr merge lp://staging/~ttosttos/eidete/fix-1004294
Reviewer Review Type Date Requested Status
Victor Martinez (community) Approve
Review via email: mp+109065@code.staging.launchpad.net

Description of the change

- Added gettext domain key to eidete.desktop
- created desktop_launcher.vala to have xgettext automatically add launcher strings to translation template

To post a comment you must log in.
Revision history for this message
ttosttos (ttosttos) wrote :

Earlier merge requests has been sitting for some time. I'd appreciate if someone can review and comment or otherwise merge. Thanks.

Revision history for this message
Victor Martinez (victored) wrote :

Eidete dev(s) seem to be busy. This looks fine to me.

review: Approve
Revision history for this message
ttosttos (ttosttos) wrote :

@victored, thanks for approving. Is merge still pending? Status is marked as "needs review". Thanks again.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: