Merge lp://staging/~tribaal/landscape-client/take-two-1434546-exit-code-2-on-error into lp://staging/~landscape/landscape-client/trunk

Proposed by Chris Glass
Status: Merged
Approved by: Chris Glass
Approved revision: 818
Merged at revision: 815
Proposed branch: lp://staging/~tribaal/landscape-client/take-two-1434546-exit-code-2-on-error
Merge into: lp://staging/~landscape/landscape-client/trunk
Diff against target: 183 lines (+67/-11)
2 files modified
landscape/configuration.py (+13/-2)
landscape/tests/test_configuration.py (+54/-9)
To merge this branch: bzr merge lp://staging/~tribaal/landscape-client/take-two-1434546-exit-code-2-on-error
Reviewer Review Type Date Requested Status
Alberto Donato Approve
Benji York (community) Approve
Review via email: mp+254062@code.staging.launchpad.net

Commit message

Restore behavior of the program exiting with a non-zero exit code in case of
error during registration (specifically, "2").

Description of the change

This branch restores behavior of the program exiting with a non-zero exit code in case of error during registration (specifically, "2").

To post a comment you must log in.
Revision history for this message
Benji York (benji) wrote :

Looks great. I had a couple small comments inline.

review: Approve
817. By Chris Glass

Peppin'

Revision history for this message
Chris Glass (tribaal) :
Revision history for this message
Benji York (benji) :
Revision history for this message
Alberto Donato (ack) wrote :

Looks good, +1

One minor comment inline.

review: Approve
818. By Chris Glass

Added assertion of success as requested.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: