lp://staging/~tribaal/landscape-client/fix-1429888-wrong-credentials-stacktrace

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/~landscape/landscape-client/trunk at revision 814

Björn Tillenius (community): Approve on 2015-03-20

Adam Collard (community): Approve on 2015-03-17

Diff: 144 lines (+72/-17)

2 files modified

landscape/configuration.py (+11/-6)
landscape/tests/test_configuration.py (+61/-11)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1429888: Client backtraces and hangs when incorrect account/pass is given

High

Fix Released

Link a bug report

Related blueprints

821. By Chris Glass on 2015-03-19

The test passes now. Thanks for the insight Bjorn!

820. By Chris Glass on 2015-03-19

Added test. No idea why this one fails.

819. By Chris Glass on 2015-03-17

Fixed comments.

818. By Chris Glass on 2015-03-17

PEP-257

817. By Chris Glass on 2015-03-17

Made tests more explicit (hopefully)

816. By Chris Glass on 2015-03-17

Fixed tests.

815. By Chris Glass on 2015-03-17

This fixes the behavior. We don't need a special-case for this particular
failure mode since it's the only failure mode left (and the "UI" text is already
appropriate). Adding an extra text made the assertion failed (rightfully).

814. By Chris Glass on 2015-03-12

Turns out the ordering of parameters matters in function calls.

813. By Benji York on 2015-03-10

Merge bug-1428826-restore-register-function-public-API [f=1428826] [r=adam-collard,bjornt] [a=Benji York]
Instead of running client configuration as an independent executable
(which would have been preferable), the client charm reaches inside and
calls the register() function directly. That has resulted in a
dependency on register()'s API which was not enforced via testing or
documented in register()'s docstring.

This branch restores the API the charm depends on, adds documentation as
to its meaning and importance, and adds tests that will warn us if the
API is broken in the future.

812. By Benji York on 2015-03-04

Merge better-self-signed-cert-ux-3 [f=] [r=bjornt,danilo] [a=Benji York]
This branch is a pure refactoring of the way the client configuration
communicates so as to separate the UI and network code in preparation
for better SSL error handling and user interaction.

Tests were then able to be improved -- but not as far as we would like.

Notes from Chris:

Most of the code breaks out nested function declaration to make them
easier to test, using functools.partial to keep the invocation sane in a
twisted context (test them "flat", use functools to pass closures to
event handlers).

We used manual stubs instead of mocks for readability and personal
preference [of both of us].