Merge lp://staging/~tribaal/landscape-charm/migrate-schema-action into lp://staging/~landscape/landscape-charm/trunk
Proposed by
Chris Glass
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Chris Glass | ||||
| Approved revision: | 288 | ||||
| Merged at revision: | 286 | ||||
| Proposed branch: | lp://staging/~tribaal/landscape-charm/migrate-schema-action | ||||
| Merge into: | lp://staging/~landscape/landscape-charm/trunk | ||||
| Diff against target: |
114 lines (+57/-6) 6 files modified
actions.yaml (+3/-0) actions/migrate-schema (+9/-0) lib/callbacks/scripts.py (+2/-4) lib/migrate_schema.py (+17/-0) lib/paths.py (+6/-2) lib/tests/test_migrate_schema.py (+20/-0) |
||||
| To merge this branch: | bzr merge lp://staging/~tribaal/landscape-charm/migrate-schema-action | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Free Ekanayaka (community) | Approve | ||
| 🤖 Landscape Builder | test results | Approve | |
| Alberto Donato | Approve | ||
|
Review via email:
|
|||
Commit message
This branch introduces a minimal "migrate schema" juju action that simply runs the
schema migration script.
In a future branch (tracked by bug #1456953) we will implement a slightly more
secure way of doing so.
Description of the change
This branch introduces a minimal "migrate schema" juju action that simply runs the
schema migration script.
In a future branch (tracked by bug #1456953) we will implement a slightly more
secure way of doing so.
To post a comment you must log in.
Revision history for this message
| 🤖 Landscape Builder (landscape-builder) wrote | # |
review:
Approve
(test results)
Revision history for this message
| 🤖 Landscape Builder (landscape-builder) wrote | # |
review:
Approve
(test results)
Revision history for this message
| Chris Glass (tribaal) wrote | # |
Revision history for this message
| Chris Glass (tribaal) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
+1. Looks good, with a comment inline.