Landscape Charm

Merge lp://staging/~tribaal/landscape-charm/fix-benji-comments into lp://staging/~landscape/landscape-charm/trunk

  1. fix-benji-comments
  2. Merge into trunk
Proposed by Chris Glass
Status: Merged
Approved by: Chris Glass
Approved revision: 323
Merged at revision: 323
Proposed branch: lp://staging/~tribaal/landscape-charm/fix-benji-comments
Merge into: lp://staging/~landscape/landscape-charm/trunk
Diff against target: 43 lines (+2/-10)
2 files modified
tests/helpers.py (+2/-3)
tests/test_helpers.py (+0/-7)
To merge this branch: bzr merge lp://staging/~tribaal/landscape-charm/fix-benji-comments
Reviewer Review Type Date Requested Status
Данило Шеган (community) Approve
Alberto Donato Approve
🤖 Landscape Builder test results Approve
Review via email: mp+264107@code.staging.launchpad.net

Commit message

Address comments in another merge.

Description of the change

This addresses comments from https://code.launchpad.net/~tribaal/landscape-hosted-charm/add-system-test-machinery/+merge/263868

Since they were raised on the automatically imported version I address them here (at the source) instead.

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make ci-test
Result: Success
Revno: 323
Branch: lp:~tribaal/landscape-charm/fix-benji-comments
Jenkins: https://ci.lscape.net/job/latch-test/1680/

review: Approve (test results)
Revision history for this message
Alberto Donato (ack) wrote :

+1

review: Approve
Revision history for this message
Данило Шеган (danilo) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches