Merge lp://staging/~tribaal/landscape-charm/extract_common_test_helpers into lp://staging/~landscape/landscape-charm/trunk
Proposed by
Chris Glass
| Status: | Merged |
|---|---|
| Approved by: | Chris Glass |
| Approved revision: | 244 |
| Merged at revision: | 245 |
| Proposed branch: | lp://staging/~tribaal/landscape-charm/extract_common_test_helpers |
| Merge into: | lp://staging/~landscape/landscape-charm/trunk |
| Diff against target: |
415 lines (+195/-175) 3 files modified
tests/01-begin.py (+7/-174) tests/helpers.py (+185/-0) tests/jujulib/deployer.py (+3/-1) |
| To merge this branch: | bzr merge lp://staging/~tribaal/landscape-charm/extract_common_test_helpers |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Данило Шеган (community) | Approve | ||
| Free Ekanayaka (community) | Approve | ||
| 🤖 Landscape Builder | test results | Approve | |
|
Review via email:
|
|||
Commit message
This branch moves some common code into a helpers.py file (there is no actual code change), and adds a couple of conf/ file options to inject ssl_key and ssl_cert in the charm configuration.
Description of the change
This branch moves some common code into a helpers.py file (there is no actual code change), and adds a couple of conf/ file options to inject ssl_key and ssl_cert in the charm configuration.
To post a comment you must log in.
Revision history for this message
| Chris Glass (tribaal) | # |
Revision history for this message
| 🤖 Landscape Builder (landscape-builder) wrote | # |
review:
Approve
(test results)
Revision history for this message
| Данило Шеган (danilo) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Command: make ci-test
Result: Success
Revno: 244
Branch: lp:~tribaal/landscape-charm/extract_common_test_helpers
Jenkins: https:/