Landscape Charm

Merge lp://staging/~tribaal/landscape-charm/enable-package-search into lp://staging/~landscape/landscape-charm/trunk

  1. enable-package-search
  2. Merge into trunk
Proposed by Chris Glass
Status: Merged
Approved by: Chris Glass
Approved revision: 251
Merged at revision: 250
Proposed branch: lp://staging/~tribaal/landscape-charm/enable-package-search
Merge into: lp://staging/~landscape/landscape-charm/trunk
Diff against target: 266 lines (+120/-12)
7 files modified
hooks/lib/relations/landscape.py (+6/-2)
hooks/lib/relations/tests/test_landscape.py (+14/-8)
hooks/lib/services.py (+4/-1)
hooks/lib/tests/sample.py (+1/-0)
hooks/lib/tests/test_templates.py (+77/-0)
templates/landscape-server (+7/-1)
templates/service.conf (+11/-0)
To merge this branch: bzr merge lp://staging/~tribaal/landscape-charm/enable-package-search
Reviewer Review Type Date Requested Status
🤖 Landscape Builder test results Approve
Björn Tillenius (community) Approve
Free Ekanayaka (community) Approve
Review via email: mp+256290@code.staging.launchpad.net

Commit message

Enable the package-search service on the leader unit, and configures non-leader units to use the package-search service from the leader.

Description of the change

This branch enables the package-search service on the leader unit, and configures non-leader units to use the package-search service from the leader.

Charm-helpers don't seem to expose a particular way to retrieve the leader's IP from a cluster, so I "cheated" and instead use the same mechanism to propagate the information as for the secrets.

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make ci-test
Result: Success
Revno: 248
Branch: lp:~tribaal/landscape-charm/enable-package-search
Jenkins: https://ci.lscape.net/job/latch-test/478/

review: Approve (test results)
Revision history for this message
Free Ekanayaka (free.ekanayaka) wrote :

Nice work, +1. Just a couple of tests missing, see the comments.

review: Approve
Revision history for this message
Chris Glass (tribaal) wrote :

All comments should be addressed!

Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make ci-test
Result: Success
Revno: 249
Branch: lp:~tribaal/landscape-charm/enable-package-search
Jenkins: https://ci.lscape.net/job/latch-test/480/

review: Approve (test results)
Revision history for this message
Björn Tillenius (bjornt) wrote :

+1. Some comments on the tests, but nothing major.

review: Approve
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make ci-test
Result: Success
Revno: 250
Branch: lp:~tribaal/landscape-charm/enable-package-search
Jenkins: https://ci.lscape.net/job/latch-test/496/

review: Approve (test results)
Revision history for this message
Chris Glass (tribaal) :
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.

Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make ci-test
Result: Success
Revno: 251
Branch: lp:~tribaal/landscape-charm/enable-package-search
Jenkins: https://ci.lscape.net/job/latch-test/498/

review: Approve (test results)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches