Merge lp://staging/~tribaal/charm-helpers/jinja-templating into lp://staging/charm-helpers
Proposed by
Chris Glass
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 188 | ||||
| Proposed branch: | lp://staging/~tribaal/charm-helpers/jinja-templating | ||||
| Merge into: | lp://staging/charm-helpers | ||||
| Diff against target: |
80 lines (+71/-0) 2 files modified
charmhelpers/contrib/templating/jinja.py (+23/-0) tests/contrib/templating/test_jinja.py (+48/-0) |
||||
| To merge this branch: | bzr merge lp://staging/~tribaal/charm-helpers/jinja-templating | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Charles Butler (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
This branch adds standard jinja2 templating code in teh contrib.templating section, along with simple tests.
I noticed several charms use what looks like a copy-pasted solution to achieve the same result, I'll send branches against those charms in a second step.
Note: the file is not called "jinja2.py" on purpose (it would create circular imports).
To post a comment you must log in.
Revision history for this message
| James Page (james-page) | # |
Revision history for this message
| Chris Glass (tribaal) wrote | # |
Revision history for this message
| Tim Van Steenburgh (tvansteenburgh) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks, all comments should be addressed.