Merge lp://staging/~tribaal/charm-helpers/is-device-mounted-work-with-partitions into lp://staging/charm-helpers

Proposed by Chris Glass
Status: Merged
Merged at revision: 186
Proposed branch: lp://staging/~tribaal/charm-helpers/is-device-mounted-work-with-partitions
Merge into: lp://staging/charm-helpers
Diff against target: 68 lines (+45/-1)
2 files modified
charmhelpers/contrib/storage/linux/utils.py (+3/-0)
tests/contrib/storage/test_linux_storage_utils.py (+42/-1)
To merge this branch: bzr merge lp://staging/~tribaal/charm-helpers/is-device-mounted-work-with-partitions
Reviewer Review Type Date Requested Status
Liam Young (community) Approve
Review via email: mp+228987@code.staging.launchpad.net

Description of the change

This branch lets is_device-mounted() accept partitions as "device" as well as "root" devices:

In addition to "/dev/sda" being valid input, the function now accepts "/dev/sda1" as well.

To post a comment you must log in.
187. By Chris Glass

Added an extra test for an edge case.

Revision history for this message
Liam Young (gnuoy) wrote :

Approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches