Charm Helpers

Merge lp://staging/~tribaal/charm-helpers/add-documentation-to-cluster-helpers into lp://staging/charm-helpers

  1. add-documentation-to-cluster-helpers
  2. Merge into devel
Proposed by Chris Glass
Status: Merged
Merged at revision: 189
Proposed branch: lp://staging/~tribaal/charm-helpers/add-documentation-to-cluster-helpers
Merge into: lp://staging/charm-helpers
Diff against target: 202 lines (+63/-30)
2 files modified
charmhelpers/contrib/hahelpers/cluster.py (+46/-13)
tests/contrib/hahelpers/test_cluster_utils.py (+17/-17)
To merge this branch: bzr merge lp://staging/~tribaal/charm-helpers/add-documentation-to-cluster-helpers
Reviewer Review Type Date Requested Status
Charles Butler (community) Approve
Review via email: mp+229197@code.staging.launchpad.net

Description of the change

This branch makes the hahelper.cluster code a little more documented and readable by adding docstrings and renaming functions.

Old functions are left as stubs for backwards compatiblity (and print a deprecation warning).

To post a comment you must log in.
Revision history for this message
Tim Van Steenburgh (tvansteenburgh) wrote :

+1 LGTM, tests all pass.

Thanks for taking the time to improve the docs!

Someone from the ~charmers group will do the actual merge shortly.

Revision history for this message
Charles Butler (lazypower) wrote :

+1 LGTM

I discovered quite a bit about HAHelpers thanks to this merge. Great work!

review: Approve
Revision history for this message
Chris Glass (tribaal) wrote :

Nice! That's reason enough for me to continue clearing things up!

Sharing (knowledge) is caring :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches